Tidy up and optimise imports #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither of these font files are included anywhere. The font is provided by GOV.UK Frontend.
This selectively imports only the components that we actually need for the tech docs.
NickColley
reviewed
Oct 7, 2019
| @import "govuk/components/input/input"; | ||
| @import "govuk/components/tag/tag"; | ||
| @import "govuk/components/skip-link/skip-link"; | ||
| @import "govuk/components/warning-text/warning-text"; |
There was a problem hiding this comment.
When I've done this sort of thing in the past I've left in the full component list as comments for other developers ease of use but probably is an opinionated idea.
There was a problem hiding this comment.
I'm going to leave as-is, mainly because I can see a list like that going out of date relatively quickly as we introduce new components etc.
There was a problem hiding this comment.
Yeah that's a good point 👍
36degrees
added a commit
that referenced
this pull request
Oct 8, 2019
36degrees
added a commit
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printablemixin withgovuk-media-queryReduces the CSS size from 145KB to ~98KB (before gzip)
(I attempted to do the same for the JavaScript, but couldn't get Frontend to play nicely with Sprockets, so that's a job for the future)